Schedule X V3 & Angular 20 update #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package-lock.json # package.json # projects/development/src/app/app.component.ts # projects/schedule-x/angular/package.json # projects/schedule-x/angular/src/lib/calendar.component.ts
Schedule x v3
5 tasks
Contributor
|
this is awesome! thank you so much for taking this on 🎉 I'll have a look |
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular 20
I dove into the other open pr for the Angular 20 update and applied minor changes to fix the development server (#119 and schedule-x/schedule-x#1139).
The problem was that the calendar was being server-side rendered. In the server context, no document is available.
In the current dev application, the calendar still shows some wonky behavior (i.e., the dropdown doesn't always properly render). But in an external app, everything worked flawlessly. Will take a closer look at a later point to pinpoint the exact issue.
Schedule x V3
In the docs, I've noticed the request for help to migrate the package to V3 to utilize Temporal.
Docs
I've opened a PR to update the docs to reflect these changes schedule-x/schedule-x#1214